Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dataset from MOSAIKS paper #363

Merged
merged 67 commits into from
Feb 27, 2022
Merged

Conversation

iejMac
Copy link
Contributor

@iejMac iejMac commented Jan 20, 2022

No description provided.

@iejMac iejMac marked this pull request as draft January 20, 2022 06:50
@github-actions github-actions bot added the datasets Geospatial or benchmark datasets label Jan 20, 2022
@adamjstewart adamjstewart added this to the 0.3.0 milestone Feb 2, 2022
@iejMac
Copy link
Contributor Author

iejMac commented Feb 23, 2022

Screen Shot 2022-02-23 at 8 21 53 AM

Screen Shot 2022-02-23 at 8 22 07 AM

I had the plot method include the labels but maybe we should add or just put the ID?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 23, 2022
@calebrob6
Copy link
Member

adding tile/patch ID to the plot and truncating the labels to 2 decimal places would be good!

@github-actions github-actions bot added the testing Continuous integration testing label Feb 23, 2022
@calebrob6
Copy link
Member

calebrob6 commented Feb 25, 2022

Looking pretty good!

Things:

  • Docstring
  • Didn't one of the CSV files have extra weird columns? Should we replicate those in the test data?

after those feel free to mark this "Ready for review" and others will take a look

@calebrob6 calebrob6 marked this pull request as ready for review February 25, 2022 17:59
torchgeo/datasets/usavars.py Outdated Show resolved Hide resolved
torchgeo/datasets/usavars.py Show resolved Hide resolved
torchgeo/datasets/usavars.py Show resolved Hide resolved
torchgeo/datasets/usavars.py Show resolved Hide resolved
torchgeo/datasets/usavars.py Show resolved Hide resolved
@adamjstewart adamjstewart enabled auto-merge (squash) February 27, 2022 20:05
@adamjstewart adamjstewart merged commit 051d7f2 into microsoft:main Feb 27, 2022
@adamjstewart adamjstewart mentioned this pull request Jul 11, 2022
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
* Adding dataset from MOSAIKS paper

* Name change

* implementing NAIPTileIndex in USAVars

* lookup_point works

* usavars: adding extract + verify

* USAVars: add md5

* initial _load_files function

* adding plotting

* formatting

* add description

* black fix

* flake8 fix

* pydocstyle fix

* mypy fix

* add DS to docs

* black fix

* fake dataset

* add transforms arg

* initial tests

* fix black flake8 isort

* fix black flake8

* fix black

* fix mypy

* test fixes

* testing something

* it finds zip but not csv

* fake csv files didn't get added

* pandas docs fix

* forgot to take out here

* need to add in functions

* round plot labels

* Small edits

* remove Unnamed column

* zipfile change

* i think this solves codecov?

* there needs to be a test

* codecov

* bring back UAR!

* remove intermediate directory

* fix flake8

* No more iteration in load_files

* dont' use Any

* check if all csv files exist

* Add docstring to init

* use index col = ID

* labels in as list

* adjust to only 3 labels + adjust tests

* citation

* remove testing file

* no need to rename zipfile

* adding data.py to test data + adjusting tests

* formatting fixes

* style fix

* docstring

* Docstring

* Fixing docstring

* docstring for labels

* Adding all csv files to data + checking for all 7 labels instead of just 3

* docstrings

* docstring

* ensure labels are valid

* pydocstyle fix

* cast to list

* remove typos

* Requested changes

Co-authored-by: Caleb Robinson <calebrob6@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets documentation Improvements or additions to documentation testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants