Added GNDVI and SWI Indices #371
Conversation
github-actions
bot
added
documentation
|
Thanks for consolidating! It looks like the style tests are failing (see https://torchgeo.readthedocs.io/en/latest/user/contributing.html for more info about what is going on here) and unit tests are missing for the new indices (see https://github.com/microsoft/torchgeo/blob/main/tests/transforms/test_indices.py for example tests that you can copy). Let me know if this doesn't make sense and I can help out! |
github-actions
bot
removed
the
documentation
|
can this be merged now. |
|
This still needs unit tests, you should be able to copy and modify the tests for the other indices, see |
|
@adamjstewart the coverage for the various indices are actually provided by test_transforms.py, I'm going to add specific tests in test_indices.py so that it is less confusing/ conforms with the standard way of doing things |
|
Okay I think this is good to go now |
|
thank you |
tests/transforms/test_indices.py
Outdated
| AppendNDVI, | ||
| AppendNDWI, | ||
| AppendSWI, | ||
| indices, |
There was a problem hiding this comment.
Could replace this with AppendNormalizedDifferenceIndex for consistency
There was a problem hiding this comment.
It took me a startling long time to figure out what you meant here
|
|
||
| Args: | ||
| index_red: index of the VRE1 band, e.g. B5 in Sentinel 2 imagery | ||
| index_swir: index of the SWIR2 band, e.g. B11 in Sentinel 2 imagery |
There was a problem hiding this comment.
We don't add examples for other indices. Should we?
Added MNDWI to support modification of normalised difference water index (NDWI) to enhance open water features in remotely sensed imagery.
Added a new Index Soil Water Index
Style error fixed
Changed the comment to fit in the code accordingly
modified
corrected the citation
Added Dockerfile
Added GNDVI Index
Saved
deleting
|
Thanks again for the contribution @MATRIX4284 |
* Update indices.py Added MNDWI to support modification of normalised difference water index (NDWI) to enhance open water features in remotely sensed imagery. * Update indices.py * Update indices.py * Update indices.py Added a new Index Soil Water Index * Update indices.py Style error fixed * Update indices.py * SWI addition * Update indices.py * Update indices.py * Update indices.py * Update indices.py Changed the comment to fit in the code accordingly * Update indices.py modified * Update indices.py corrected the citation * Update indices.py * Ubuntu CUDA 11.3 docker for torchgeo * Update Dockerfile_ubuntu_1804_cuda_11_3_cudnn_8_torchgeo * Delete Dockerfile_ubuntu_1804_cuda_11_3_cudnn_8_torchgeo * Added Dockerfile Added Dockerfile * deleted docker due to wrong issue number * Added GNDVI Index Added GNDVI Index * corrected docstring * updated refernce index to doi * Added Triband Normalized Indexes * Update indices.py Saved * Updated GNDVI * Delete transforms.ipynb deleting * Added the notebook changes * Delete transforms.ipynb * Added the notebook changes * Added the spaces * Update indices.py * formatting corrected * Running black * Reset transforms * Clean up docstrings * Adding tests and adding to list of transforms exported by the module * Consistency Co-authored-by: Caleb Robinson <calebrob6@gmail.com>
Added GNDVI and SWI Indices