Fix regex to work with Sentinel-2 Band 8A #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regex was only finding numerical bands (e.g. Band 01, 02, ..., 10, 12), but not Band 8A.
|
|
github-actions
bot
added
datasets
Co-Authored-By: Adam J. Stewart <ajstewart426@gmail.com>
adamjstewart
approved these changes
Feb 10, 2022
|
Nice, thanks @weiji14!! |
|
If this is ready to go just click the "Ready for review" button and I can merge. |
adamjstewart
added a commit
that referenced
this pull request
Mar 19, 2022
* Fix regex to work with Sentinel-2 Band8A Regex was only finding numerical bands (e.g. Band 01, 02, ..., 10, 12), but not Band 8A. * Update test_sentinel to include Band 8A * Simplify regex Co-Authored-By: Adam J. Stewart <ajstewart426@gmail.com> Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
* Fix regex to work with Sentinel-2 Band8A Regex was only finding numerical bands (e.g. Band 01, 02, ..., 10, 12), but not Band 8A. * Update test_sentinel to include Band 8A * Simplify regex Co-Authored-By: Adam J. Stewart <ajstewart426@gmail.com> Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regex was only finding numerical bands (e.g. Band 01, 02, ..., 10, 12), but not Band 8A. Change
B\d{2}to the more specificB[018][\dA].