Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plot method and data.py to Sentinel Dataset #416

Merged
merged 2 commits into from
Feb 21, 2022

Conversation

nilsleh
Copy link
Collaborator

@nilsleh nilsleh commented Feb 20, 2022

Since RasterDatasets should have their own plot method per #253, this PR adds a plot method as well as a data.py file with adapted fake data to the the Sentinel dataset.

@github-actions github-actions bot added datasets Geospatial or benchmark datasets testing Continuous integration testing labels Feb 20, 2022
@adamjstewart adamjstewart added this to the 0.3.0 milestone Feb 20, 2022
@calebrob6
Copy link
Member

Some examples (@nilsleh, do you remember if we use 3000 as the standard normalization in other S2 datasets?)

image

image

@nilsleh
Copy link
Collaborator Author

nilsleh commented Feb 21, 2022

sen12ms, benin_cashews and eurosat use the 3000 normalization. BigEarthNet uses 2000.

@calebrob6
Copy link
Member

awesome, the planetary computer examples use 3000 too, so let's just go with that (side note: we might want to make this an argument at some point since snowy scenes are very bright and dividing by a larger constant is better in those cases)

@calebrob6 calebrob6 merged commit 6bc3779 into microsoft:main Feb 21, 2022
This was referenced Jul 10, 2022
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
* add plot method and data.py

* Adding normalization for plot

Co-authored-by: Caleb Robinson <calebrob6@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants