CDL: don't pick up .tif.ovr files #424
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, tests are crashing for the reason I thought... I guess we could specify the extension in the |
isaaccorley
previously approved these changes
Feb 21, 2022
|
Turns out that CDL used to be distributed as .img files but is now distributed as .tif files. So the change in this PR is correct, we just need to change the fake test data files first. |
|
Depends on #429 |
calebrob6
force-pushed
the
datasets/cdl
branch
from
1fd4705
to
75f7926
Compare
|
rebased on main |
calebrob6
approved these changes
Feb 26, 2022
adamjstewart
added a commit
that referenced
this pull request
Mar 19, 2022
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #423
Maybe someone with a wired internet connection can double check that every year of data has a
.tiffile? From what I call, this dataset was not consistent across all years. I feel like some years might have used.img...Unfortunately this prevents users from changing the file format of the data they download. But those users can always override
filename_globif they need to.