Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAVars: implementing DataModule #441

Merged
merged 25 commits into from
Jun 27, 2022

Conversation

iejMac
Copy link
Contributor

@iejMac iejMac commented Mar 1, 2022

No description provided.

@iejMac iejMac marked this pull request as draft March 1, 2022 04:51
@github-actions github-actions bot added the datamodules PyTorch Lightning datamodules label Mar 1, 2022
@adamjstewart adamjstewart added this to the 0.3.0 milestone Mar 1, 2022
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 2, 2022
@github-actions github-actions bot added testing Continuous integration testing datasets Geospatial or benchmark datasets labels Mar 13, 2022
@calebrob6
Copy link
Member

When #460 is merged, then a rebase on main should fix the mypy tests.

@iejMac iejMac marked this pull request as ready for review March 14, 2022 01:39
@adamjstewart
Copy link
Collaborator

#460 has been merged. Can you rebase this?

@adamjstewart adamjstewart enabled auto-merge (squash) June 27, 2022 00:35
@adamjstewart adamjstewart merged commit 7b5a92b into microsoft:main Jun 27, 2022
@adamjstewart adamjstewart mentioned this pull request Jul 11, 2022
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
* USAVars: implementing DataModule

* Adding initial version

* add to __init__

* changes

* add transforms argument

* black, isort fix

* fixed shuffle option

* update docs

* fix formatting

* initial split method

* fix formatting

* testing for datamodule

* this is simpler

* testing seed

* fix isort + test seed

* refactor dataset for splits

* black fix

* adding splits to fake data

* change test splits

* working tests locally

* fix black

* fix black

* adapt module to dataset refactor

* complete docstring

* Style fixes

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodules PyTorch Lightning datamodules datasets Geospatial or benchmark datasets documentation Improvements or additions to documentation testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants