RandomGeoSampler: several bug fixes #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
samplers
calebrob6
reviewed
Mar 30, 2022
| # Choose a random tile | ||
| hit = random.choice(self.hits) | ||
| # Choose a random tile, weighted by area | ||
| idx = torch.multinomial(self.areas, 1) |
There was a problem hiding this comment.
this defaults to sampling without replacement -- is that the intention here?
There was a problem hiding this comment.
We only sample a single idx at a time so replacement wouldn't affect anything.
calebrob6
approved these changes
Apr 5, 2022
remtav
pushed a commit
to remtav/torchgeo
that referenced
this pull request
May 26, 2022
* RandomGeoSampler: prevent area bias * Use builtin PyTorch random Co-authored-by: Caleb Robinson <calebrob6@gmail.com>
Merged
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
* RandomGeoSampler: prevent area bias * Use builtin PyTorch random Co-authored-by: Caleb Robinson <calebrob6@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following fixes:
size=0queries to handle point datasize=(height, width)queries for entire tile at a timeThe first requires #375 so has to be in 0.3.0. The rest could theoretically be backported to 0.2.2 but I'm not really planning on a 0.2.2 release at the moment.