Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case of missing label in Forest Damage dataset #499

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

nilsleh
Copy link
Collaborator

@nilsleh nilsleh commented Apr 5, 2022

When using this dataset, I discovered that 3 of the more than 100,000 bounding boxes are missing a label, and thus breaking the __getitem__.

Changes:

  • use the no class label when bounding box has no label
  • new test data to cover this case

@nilsleh nilsleh changed the title Fix case of missing label Fix case of missing label in Forest Damage dataset Apr 5, 2022
@github-actions github-actions bot added datasets Geospatial or benchmark datasets testing Continuous integration testing labels Apr 5, 2022
@calebrob6
Copy link
Member

Is this a problem with the actual dataset? If so, can you inform the authors?

@nilsleh
Copy link
Collaborator Author

nilsleh commented Apr 5, 2022

Is this a problem with the actual dataset? If so, can you inform the authors?

Yes, I believe so. I checked the raw xml files, and send an email to the authors. They said they will look into it.

calebrob6
calebrob6 previously approved these changes Apr 5, 2022
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you ever hear back from the authors, let us know. I'm guessing they'll re-release the dataset without changing the version or URL, so the checksum will change. In that case we can simply revert this PR and change the checksum.

@adamjstewart adamjstewart merged commit 4fadc24 into microsoft:main Apr 8, 2022
remtav pushed a commit to remtav/torchgeo that referenced this pull request May 26, 2022
@adamjstewart adamjstewart added this to the 0.3.0 milestone Jul 10, 2022
@adamjstewart adamjstewart mentioned this pull request Jul 11, 2022
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants