Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue templates #590

Merged
merged 2 commits into from
Jun 19, 2022
Merged

Add issue templates #590

merged 2 commits into from
Jun 19, 2022

Conversation

adamjstewart
Copy link
Collaborator

This PR adds issue templates to the repository. They are loosely based on PyTorch's and Spack's issue templates. See the official docs for more details on possible values and syntax.

I don't really know how to view/test these without forking the repo and merging them to main in the fork? I guess we can do all the wordsmithing in this PR and fix any bugs we find after merging.

Closes #584

@github-actions github-actions bot added the testing Continuous integration testing label Jun 18, 2022
required: true
- type: input
attributes:
label: Version
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of just the TorchGeo version, we could expand this to the full development environment, including:

  • OS: e.g., macOS 12.4
  • Python: e.g., 3.9.12
  • TorchGeo: e.g., 1.2.3.dev0 (e1285e6)
  • Installation method: e.g., pip, conda, spack, git, etc.
  • Dependency versions: e.g., pip list, conda list, spack find, etc.

I'm not sure how useful the rest of these are since TorchGeo is pure-Python and pretty heavily tested...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think torchgeo version is fine for now (i.e. until we see something crazy that is not caught by tests or explained by dependency/Python version)

Thanks for taking the time to report this bug! TorchGeo is an open-source project
maintained by its users. If you're Python savvy and want to contribute a pull
request to fix this bug, we'll be happy to review it. If not, we'll try to fix it
as long as we can reproduce it.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to clarify that TorchGeo isn't a commercial product with a team of developers just waiting to fix your bugs lol

blank_issues_enabled: true
contact_links:
- name: ❓ Questions
url: https://github.com/microsoft/torchgeo/discussions
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could replace this with a Slack invite link if we ever decide to go down that route

required: true
- type: textarea
attributes:
label: Steps to reproduce
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of other repos have sections for "expected result" and "actual result" but I always find myself writing something like "I would expect this to work" and "it doesn't work" so I've never found those sections super useful. Hopefully users will clarify when things don't work as they would expect.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...
```
validations:
required: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is making the reproducible example required. I don't want someone to not report something just because they have to provide a reproducible example. Maybe we can explain that bugs are much easier to fix if there is reproducible code and we don't have a lot of free time to make our own examples?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having a reproducible example is a low bar. At the bare minimum, just upload the code you ran and the files you ran it on to produce the error message. Having a minimal reproducible example is a bigger hurdle, but users rarely consider that to be a requirement unfortunately. If someone reported an issue with just an error message and didn't tell me how they got that error message, I would probably just close the issue. I would go so far as to say having a reproducible example is the only thing that is absolutely required to report an issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's totally fine -- just a minor concern! The more I think about it the more I agree, we really don't have a ton of time to dig into things (esp. if they are obscure).

@adamjstewart
Copy link
Collaborator Author

Added a note explaining the scope of features we accept. I think having a reproducible example should absolutely be required.

@adamjstewart adamjstewart merged commit d0a2008 into main Jun 19, 2022
@adamjstewart adamjstewart deleted the issues/template branch June 19, 2022 17:47
@adamjstewart
Copy link
Collaborator Author

@adamjstewart adamjstewart mentioned this pull request Jul 11, 2022
@adamjstewart adamjstewart added this to the 0.3.0 milestone Jul 11, 2022
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
* Add issue templates

* Explain scope of TorchGeo features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add issue template
2 participants