Store Python 3.7 deps in separate files, use rasterio/fiona Windows wheels #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
…heels (microsoft#647) * Store Python 3.7 deps in separate files, use rasterio/fiona Windows wheels * Fix fiona 1.9 warning * Fix import error * Try again * Expand obj kwargs * Fiona still support Python 3.7 * Investigate segfaults * Undo last commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rasterio and fiona both have Windows wheels now. The only time we need to use conda in CI is to install rasterio on Windows for Python 3.7 which is no longer supported. Once we drop Python 3.7 support (about 12 months from now) conda will no longer be needed in CI.
This PR also stores all dependencies that require a different version for Python 3.7 in separate files. This prevents dependabot from updating them and reporting security vulnerabilities. These files will need to be updated once the numpy ecosystem drops Python 3.8 support.