Fix NDVI and SWI calculation #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
isaaccorley
approved these changes
Aug 17, 2022
Modexus
pushed a commit
to Modexus/torchgeo
that referenced
this pull request
Sep 3, 2022
* Fix NDVI and SWI calculation * Escape LaTeX code
adamjstewart
added a commit
that referenced
this pull request
Sep 3, 2022
* Fix NDVI and SWI calculation * Escape LaTeX code
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
* Fix NDVI and SWI calculation * Escape LaTeX code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #713
We were calculating NDVI incorrectly, using (Red - NIR) instead of (NIR - Red). The only reason our plots looked correct is that we were inverting the color scales.
We used the incorrect band names for SWI. This PR fixes those as well.
I double checked all other indices and things look correct, but I would appreciate it if someone else could triple check.
I'll see if I can get our blog fixed as well.
@cagsen @isaaccorley @MATRIX4284