Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix torchvision constraint #761

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Fix torchvision constraint #761

merged 1 commit into from
Sep 6, 2022

Conversation

ashnair1
Copy link
Collaborator

@ashnair1 ashnair1 commented Sep 6, 2022 •
edited by adamjstewart

Multi-Weights API was introduced in 0.13. This PR adjusts the constraint accordingly.

@github-actions github-actions bot added models Models and pretrained weights testing Continuous integration testing trainers PyTorch Lightning trainers labels Sep 6, 2022
adamjstewart
adamjstewart requested changes Sep 6, 2022
View reviewed changes
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know how I missed this, thanks for catching this!

Can you use >= parse("0.13") instead? > parse("0.12") also includes 0.12.1 which would not have this feature.

@adamjstewart adamjstewart added this to the 0.3.1 milestone Sep 6, 2022
@ashnair1
Copy link
Collaborator Author

ashnair1 commented Sep 6, 2022

No problem 👍 . torchvision doesn't have a 0.12.1 though. Refer pypi

@adamjstewart
Copy link
Collaborator

Not yet. And it probably won't, but they could release a patch release to fix an important bug.

@adamjstewart adamjstewart merged commit f6a9f75 into microsoft:main Sep 6, 2022
adamjstewart pushed a commit that referenced this pull request Sep 6, 2022
@ashnair1 @adamjstewart
Fix torchvision constraint (#761)
2d234a7
@ashnair1 ashnair1 deleted the constraint-fix branch September 6, 2022 16:41
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
@ashnair1
Fix torchvision constraint (microsoft#761)
3b87caf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjstewart adamjstewart adamjstewart approved these changes

Assignees
No one assigned
Labels
models Models and pretrained weights testing Continuous integration testing trainers PyTorch Lightning trainers
Projects
None yet
Milestone
0.3.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashnair1 @adamjstewart