Remove "labels" folder from verify for xView2 #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `labels` folder exists for the `tier3` imagery that was released after the `tier1` imagery for xView2. It should really be called `targets` but we messed up. When you're merging `tier1` with `tier3`, simply copy all the files from `tier3/labels` to `tier1/targets`.
RitwikGupta
changed the title
|
We should also update the docs to explain to users that they need to manually move tier3 labels into the tier1 folder. |
|
I would prefer that the TorchGeo dataset "just works" without the user needing to change anything on their part. If the download still has that directory in the latest version, we should support it. |
|
The download has that directory, but the dataset does not use it whatsoever. The user has to actually manually convert Tier3 JSON labels to masks, but the dataset doesn't do anything with the labels folder. Therefore, there's no reason to check for its existence. |
adamjstewart
approved these changes
Sep 22, 2022
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
The `labels` folder exists for the `tier3` imagery that was released after the `tier1` imagery for xView2. It should really be called `targets` but we messed up. When you're merging `tier1` with `tier3`, simply copy all the files from `tier3/labels` to `tier1/targets`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
labelsfolder exists for thetier3imagery that was released after thetier1imagery for xView2. It should really be calledtargetsbut we messed up. When you're mergingtier1withtier3, simply copy all the files fromtier3/labelstotier1/targets.