Add plot method to (most) DataModules #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datamodules
calebrob6
reviewed
Oct 4, 2022
adamjstewart
force-pushed
the
datamodules/plot
branch
from
54c887d
to
e4a1c02
Compare
|
Okay, I backed out a few datamodule plot methods that were broken. Those can be added one at a time in future PRs by anyone who cares. I'm still hoping to add plot methods to most datamodules, even if normalization may make visualization a bit broken. I'm not really sure what to do about those other than undo datamodule-specific normalizations inside datamodule plot methods before passing to dataset plot methods. |
adamjstewart
changed the title
ashnair1
approved these changes
Oct 16, 2022
calebrob6
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that (almost) all of our Datasets have a plot method, our DataModules should too. This PR adds a plot method to all DataModules except:
all of which require custom logic to undo transforms. This can be saved for an adventurous contributor in a follow-up PR.