Add plot method for VHR10 dataset #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datasets
ashnair1
force-pushed
the
vhr10-plot-method
branch
2 times, most recently
from
ae05b72
to
43a7162
Compare
ashnair1
force-pushed
the
vhr10-plot-method
branch
from
2febe32
to
0ad37dd
Compare
There was a problem hiding this comment.
More minor comments. My main concerns so far are:
- Handling of COCO polygons seems to be much more complex than it used to be
- Lots of very recent dependency versions
It would be good to have a justification for these things. Complexity is fine if it's necessary but I always try to avoid it if it isn't. I haven't gotten a chance to play around with finding the minimum versions, but you can always drop the version repeatedly in the file until CI starts to fail to find a lower bound.
ashnair1
force-pushed
the
vhr10-plot-method
branch
2 times, most recently
from
14582c6
to
7251032
Compare
ashnair1
force-pushed
the
vhr10-plot-method
branch
from
d7cde67
to
7ba58cd
Compare
adamjstewart
reviewed
Dec 7, 2022
ashnair1
force-pushed
the
vhr10-plot-method
branch
from
3c04942
to
6eb0afd
Compare
adamjstewart
previously approved these changes
Jan 22, 2023
|
Will move |
adamjstewart
previously approved these changes
Jan 23, 2023
adamjstewart
approved these changes
Jan 23, 2023
|
LGTM! |
Closed
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
* Add plot fn & rename nwpu -> vhr10 * Update test data & add data.py * Add scikit-image dependency * Move scikit-image dep to extras * Comment out check for coverage * Move skimage import * Update requirements * Test requirements * Update requirements * Update * Update * Update * Update * Update * Update min scipy * Update min scipy * Update min scipy * Update min scipy * Update min scipy * Update skimage * Review comments#1 * Update skimage * Revert rename to nwpu * Revert renames * Update min scipy * Fix data dirname * More fixes * Bump numpy minor version * Update scipy * Going back to what worked * Ignore numpy warning * Edit * Edit warning * Ignore another warning * Insanity * Fix pooch * Try older skimage * Try older scipy * scipy 1.2.0 * scipy 1.4.0 * scipy 1.5.0 * scipy 1.4.2 * scipy 1.6.0 * scipy 1.5.4 * scipy 1.5.2 * scipy 1.5.1 * scipy 1.5.1 is new min dep version * Fix skip * Newer scipy * scipy 1.6.3 * scipy 1.6.0 * scipy 1.6.1 * scipy 1.6.2 * scipy 1.6.2 is new min Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of splitting #798 into separate PRs.
Summary of changes:
nwpu.pytovhr10.py.scikit-imagedependencyscipyExample plots:
Ground truth and predicition (object detection training)
Controlling features to be shown and their respective opacity
Closes #894