Fix a bug for ETCI2021 loader #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="IBM" |
ashnair1
reviewed
Oct 20, 2022
adamjstewart
approved these changes
Oct 20, 2022
|
I think this is the reason: |
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
* Fix a bug for ETCI2021 loader * apply black * Remove the slashes * Removed unused lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the ETCI 2021 Data loader by removing glob for each folder
Details
I tried ETCI2021DataModule (on Mac), then found a bug for loading the images.
The loaded images are sometimes not correct by each sorted glob
You can find the image file paths are not same (of vv and water_mask) in attached result.
This PR changes the loader will do sorted glob once in vv folder, and then use it for others.