Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transforms to UnionDataset and IntersectionDataset #870

Merged
merged 6 commits into from
Nov 15, 2022
Merged

Add transforms to UnionDataset and IntersectionDataset #870

merged 6 commits into from
Nov 15, 2022

Conversation

pmandiola
Copy link
Contributor

@pmandiola pmandiola commented Oct 26, 2022 •
edited by adamjstewart

This PR adds the feature described in #867

Closes #867

@github-actions github-actions bot added the datasets Geospatial or benchmark datasets label Oct 26, 2022
adamjstewart
adamjstewart reviewed Oct 27, 2022
View reviewed changes
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing because we need to add a unit test to hit this new code.

torchgeo/datasets/geo.py Outdated Show resolved Hide resolved
@adamjstewart adamjstewart added this to the 0.4.0 milestone Oct 27, 2022
@github-actions github-actions bot added the testing Continuous integration testing label Oct 27, 2022
@calebrob6 calebrob6 merged commit b2bef78 into microsoft:main Nov 15, 2022
@calebrob6
Copy link
Member

Thanks @pmandiola!

yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
@pmandiola
Add transforms to UnionDataset and IntersectionDataset (microsoft#870)
faa5717 
* add transforms to UnionDataset

* add transforms to IntersectionDataset

* add versionadded to docstring

* transform after collate

* add tests

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjstewart adamjstewart adamjstewart approved these changes

Assignees
No one assigned
Labels
datasets Geospatial or benchmark datasets testing Continuous integration testing
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

Can't add transforms to UnionDataset or IntersectionDataset
3 participants
@pmandiola @calebrob6 @adamjstewart