Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change segmentation model argument names #919

Merged
merged 7 commits into from
Dec 13, 2022
Merged

Change segmentation model argument names #919

merged 7 commits into from
Dec 13, 2022

Conversation

nilsleh
Copy link
Collaborator

@nilsleh nilsleh commented Nov 27, 2022

Change the argument name for the tasks according to comment in #854, and add doc strings.

@github-actions github-actions bot added scripts Training and evaluation scripts testing Continuous integration testing trainers PyTorch Lightning trainers labels Nov 27, 2022
@adamjstewart adamjstewart added the backwards-incompatible Changes that are not backwards compatible label Nov 27, 2022
@adamjstewart adamjstewart added this to the 0.4.0 milestone Nov 27, 2022
adamjstewart
adamjstewart previously approved these changes Nov 27, 2022
View reviewed changes
calebrob6
calebrob6 previously approved these changes Dec 1, 2022
View reviewed changes
adamjstewart
adamjstewart reviewed Dec 4, 2022
View reviewed changes
evaluate.py Outdated Show resolved Hide resolved
@nilsleh nilsleh dismissed stale reviews from calebrob6 and adamjstewart via f132208 December 5, 2022 08:30
adamjstewart
adamjstewart requested changes Dec 7, 2022
View reviewed changes
tests/conf/chesapeake_cvpr_7.yaml Show resolved Hide resolved
tests/conf/chesapeake_cvpr_prior.yaml Show resolved Hide resolved
tests/conf/sen12ms_s1.yaml Outdated Show resolved Hide resolved
@adamjstewart adamjstewart enabled auto-merge (squash) December 8, 2022 19:53
auto-merge was automatically disabled December 9, 2022 23:35

Pull request was closed

@adamjstewart adamjstewart reopened this Dec 9, 2022
@adamjstewart adamjstewart merged commit d5ff69c into microsoft:main Dec 13, 2022
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
@nilsleh @adamjstewart
Change segmentation model argument names (microsoft#919)
d42e1a3 
* name change semgmentation model

* chmod evaluate.py

* fix variable name evaluate

* encoder -> backbone

* remove backbone_output_stride from confs

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjstewart adamjstewart adamjstewart approved these changes

@calebrob6 calebrob6 calebrob6 left review comments

Assignees
No one assigned
Labels
backwards-incompatible Changes that are not backwards compatible scripts Training and evaluation scripts testing Continuous integration testing trainers PyTorch Lightning trainers
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nilsleh @calebrob6 @adamjstewart