Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix landcoverai datamodule #959

Merged
merged 1 commit into from
Dec 17, 2022
Merged

Fix landcoverai datamodule #959

merged 1 commit into from
Dec 17, 2022

Conversation

calebrob6
Copy link
Member

Currently we add 1 to the LandCover.AI class indices. This causes several problems:

  • We don't ignore the resulting 0 class index in training so the default train configuration doesn't work
  • torchmetrics doesn't compute mIoU correctly because it thinks we have 6 classes (but we only have 5)
  • Plotting doesn't work in the validation step of training

I don't see any upside to adding 1, so I removed it!

@github-actions github-actions bot added the datamodules PyTorch Lightning datamodules label Dec 17, 2022
@adamjstewart adamjstewart added this to the 0.3.2 milestone Dec 17, 2022
@calebrob6 calebrob6 merged commit fb514a5 into main Dec 17, 2022
@calebrob6 calebrob6 deleted the landcoverai_fix branch December 17, 2022 18:18
@adamjstewart adamjstewart modified the milestones: 0.3.2, 0.4.0 Jan 23, 2023
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
@calebrob6
Fix landcoverai datamodule (microsoft#959)
c064015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjstewart adamjstewart adamjstewart approved these changes

Assignees
No one assigned
Labels
datamodules PyTorch Lightning datamodules
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@calebrob6 @adamjstewart