Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle make_range op always returning tensor of stride 1 #60

Closed
nhat-nguyen opened this issue Nov 16, 2023 · 0 comments
Closed

Handle make_range op always returning tensor of stride 1 #60

nhat-nguyen opened this issue Nov 16, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@nhat-nguyen
Copy link
Collaborator

Our implementation in Pointer analysis assumes that make_range can create tensors of varying strides. For example, tt.make_range {end = 4096, start = 2048} : tensor <1024xi32> can create a tensor of size 1024 with stride == 2. However, in triton-lang/triton#2660, the new make_range's verifier states that stride must always be 1. We need to update our lit tests and visitOperandMakeRange's stride calculation to reflect this new requirement.

Related #53
@nhat-nguyen nhat-nguyen mentioned this issue Nov 16, 2023
Closed
@manbearian manbearian added the bug Something isn't working label Nov 17, 2023
@nhat-nguyen nhat-nguyen mentioned this issue Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nhat-nguyen @manbearian