Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider setting the __esModule marker in createExporter #27

Closed
aluanhaddad opened this issue Mar 7, 2017 · 0 comments · Fixed by #28
Closed

consider setting the __esModule marker in createExporter #27

aluanhaddad opened this issue Mar 7, 2017 · 0 comments · Fixed by #28

Comments

@aluanhaddad
Copy link
Contributor

aluanhaddad commented Mar 7, 2017 •
edited

Currently, the createExporter function does not set the '__esModule' flag on the exports object.

A recent override in the jspm/registry#1040 to support this library for jspm@0.17/SystemJS@0.20 caused this package to fail under jspm@0.16/SystemJS@0.19.
That issue, as reported in #26, was fixed for the latter scenario by @frankwallis in jspm/registry#1041 but naturally breaks the former scenario once again.

In attempting to find a fix that would work for both versions, I found that specifying the __esModule flag on the exports object in createExporter results in the correct behavior.

I'm not sure if this is the right way or the right place to resolve the issue.

See also microsoft/TypeScript#13709 and systemjs/systemjs#1587
aluanhaddad added a commit to aluanhaddad/tslib that referenced this issue Mar 7, 2017
@aluanhaddad
set the __esModule marker in createExporter
e09e54d 
Resolves microsoft#27
aluanhaddad added a commit to aluanhaddad/tslib that referenced this issue Mar 7, 2017
@aluanhaddad
nl (+1 squashed commits)
d72dfe6 
Squashed commits:

[e09e54d] set the __esModule marker in createExporter

Resolves microsoft#27
@aluanhaddad aluanhaddad mentioned this issue Mar 7, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set the __esModule marker in createExporter aluanhaddad/tslib
1 participant
@aluanhaddad