Update __spreadArray helper #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone review please? We would need to ship an updated |
DanielRosenwasser
approved these changes
Jun 11, 2021
|
@DanielRosenwasser can you let me know when this is published? As far as versioning is concerned, this is a backwards compatible change (the only slight difference would be for |
|
@rbuckton it sounds like for any existing user (ignoring people manually writing out weird references to tslib), this is backwards-compatible. Otherwise, it's just enabling TypeScript 4.4 to make a breaking change. Is that accurate? |
|
I'm going to version this as 2.3.0. |
|
Its not even a breaking change. TS 4.4 would work with old tslib, but would be slower and have the older incorrect array-packing behavior, and TS 4.3 will work with the new tslib and likely be faster but mostly maintaining the older incorrect array-packing behavior. |
|
2.3.0 should be available shortly. |
This was referenced Jun 11, 2021
This was referenced Jul 2, 2021
1 task
1 task
This was referenced Jul 8, 2021
1 task
This was referenced Jul 18, 2021
1 task
This was referenced Jul 25, 2021
This was referenced Aug 5, 2021
bors bot
added a commit
to foosbyte/kicker-trainer
that referenced
this pull request
Oct 19, 2021
1440: fix: update dependency tslib to v2.3.1 (master) r=renovate[bot] a=renovate[bot] [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [tslib](https://www.typescriptlang.org/) ([source](https://togithub.com/Microsoft/tslib)) | [`2.1.0` -> `2.3.1`](https://renovatebot.com/diffs/npm/tslib/2.1.0/2.3.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Microsoft/tslib</summary> ### [`v2.3.1`](https://togithub.com/Microsoft/tslib/releases/2.3.1) [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.3.0...2.3.1) This release updates the `__spreadArray` helper for TypeScript 4.4 to correctly operate on collections that are not "concat-spreadable" such as the DOM's `NodeList`s and `HTMLCollection`s. ### [`v2.3.0`](https://togithub.com/Microsoft/tslib/releases/2.3.0) [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.2.0...2.3.0) This release updates tslib to use TypeScript 4.4's upcoming `__spreadArray` helper which correctly preserves sparse array inputs (e.g. arrays containing "missing" elements like `[1, 2, , 4]`). This new version of `__spreadArray` is backwards-compatible and is often also faster. See [microsoft/tslib#151 for more details. ### [`v2.2.0`](https://togithub.com/Microsoft/tslib/releases/2.2.0) [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.1.0...2.2.0) This release supports TypeScript 4.3's new functionality for ECMAScript private methods and accessors, and private static class members. It does so by expanding the scope of `__classPrivateFieldGet` and `__classPrivateFieldSet`. See [microsoft/tslib#146 for more details. </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/foosbyte/kicker-trainer). Co-authored-by: Renovate Bot <bot@renovateapp.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
__spreadArrayhelper to align with microsoft/TypeScript#44527