Do not add __esModule to window/global #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
approved these changes
Nov 8, 2017
|
looks good - thanks for the quick fix. wondering though, perhaps this deserves a test? |
|
因崔斯汀! @rbuckton could you publish a patch version to npm? |
|
CC: @DanielRosenwasser. Could you publish a patch update? |
|
@DanielRosenwasser - can we please have a patch update for this? |
|
Sorry about the delay, 1.8.1 should be out now on your preferred package manager. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #32 (comment), but does not necessarily fix the parent issue.