Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nock to devDependencies #98

Closed
wesemann opened this issue Oct 31, 2018 · 0 comments
Closed

Add nock to devDependencies #98

wesemann opened this issue Oct 31, 2018 · 0 comments

Comments

@wesemann
Copy link

I think it would be better to add a mocking library which nock is to the devDependencies, because this should not be deployed on production systems. Other opinions about this?
christlang added a commit to christlang/typed-rest-client that referenced this issue Oct 31, 2018
@christlang
moving nock from dependency to devDependencies
3f6f232 
microsoft#98
* is used only in tests
* will brings a lot transitive dependencies into production environment
@christlang christlang mentioned this issue Oct 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wesemann @damccorm