Expose processResponse method #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's discuss. Was there a reason for not exposing HEAD? |
|
Yeah, there was some discussion here and some offline discussion as well (I think?). Basically, we decided HEAD isn't a REST concept and didn't want to expose it since the typed-rest-client is supposed to be a general purpose client, not just servicing the node-api. Agreed that I'm not sure if we want to do this though. The question I think we have to answer is are we comfortable bumping the major version on any breaking change to processHttpResponse? I think as I consider it now I tend to lean towards no, but obviously that's not where I was 4 months ago. Overall I'd be more inclined to just close this and move on though. |
|
Let's go with that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if we actually want to do this, but if we're not going to expose HEAD for the restClient, it could be useful to at least expose processResponse for users who want to have a consistent way of accessing responses. A good example of this is azure-devops-node-api, which would probably have to replicate this code if its not exposed in order to solve this issue.