Skip to content
This repository has been archived by the owner on Jun 11, 2020. It is now read-only.

Node.js types are incorrect/outdated #52

Closed
mike-morr opened this issue Jul 10, 2016 · 9 comments
Closed

Node.js types are incorrect/outdated #52

mike-morr opened this issue Jul 10, 2016 · 9 comments

Comments

@mike-morr
Copy link

Steps to reproduce:

npm install @types/node

Expected Results:

The node v6 typings should be in index.d.ts in the node_modules/@types/node directory.

Actual Results:

The node v4 typings are in index.d.ts in the node_modules/@types/node directory.

@mhegazy
Copy link
Contributor

mhegazy commented Jul 11, 2016

The definition file is what is on definitelytyped (https://github.com/DefinitelyTyped/DefinitelyTyped/blob/types-2.0/node/index.d.ts). Please send DefinitelyTyped a PR for the updated definitions, and i will get it published to @types

@mike-morr
Copy link
Author

Master Branch

I guess typings installs from the master branch by default?

@mhegazy
Copy link
Contributor

mhegazy commented Jul 11, 2016

We should be doing a merge from master in the next few days.

@mhegazy
Copy link
Contributor

mhegazy commented Jul 11, 2016

@rakatyal can we get a merge done this week?

@felixfbecker
Copy link

Why are the typings not built from https://github.com/types/env-node?

@mhegazy
Copy link
Contributor

mhegazy commented Aug 27, 2016

The packages are published from definitlytyped, if you believe this is more accurate feel free to update the one in definitlytyped to match it.

@blakeembrey
Copy link

blakeembrey commented Aug 27, 2016

@mhegazy Can we try to prioritise redirects so duplicated efforts can be reduced ASAP? @types can even support NPM installs directly using git but a lot of people find it difficult to contribute to DefinitelyTyped (especially if they'd want to help maintain a definition instead of contributing it once and forgetting about it).

Edit: You can also use @types as a publish target directly, if there's a spec on what needs to be done to support that.

@mhegazy
Copy link
Contributor

mhegazy commented Aug 29, 2016

For context, redirects is tracked by #4

We would be happy to take PRs for this feature if anyone is interested in contributing. most of the infrastructure is already in place.

@ghost
Copy link

ghost commented Oct 19, 2016

Looks like this can be closed now as @types/node now has 6.0 typings and we have a separate issue for redirects.

@ghost ghost closed this as completed Oct 19, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants