Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Diagnostic code shown in Problems view is unpleasant #16

Closed
egamma opened this issue Nov 1, 2018 · 3 comments
Closed

Diagnostic code shown in Problems view is unpleasant #16

egamma opened this issue Nov 1, 2018 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@egamma
Copy link
Member

egamma commented Nov 1, 2018

Testing: microsoft/vscode#62092

See the screenshot below and notice:

  • each tslint diagnostic has the same diagnostic code 10000
  • each diagnostic includes the rule name

At some point it was discussed that error code are strings in the TS language service. If that would be the case then tslint could use the rule name as the diagnostic code

image

Same problem with diagnostic hover

image

@mjbvz mjbvz transferred this issue from microsoft/vscode-typescript-tslint-plugin Nov 6, 2018
@mjbvz mjbvz added the bug Something isn't working label Nov 6, 2018
@mjbvz
Copy link
Contributor

mjbvz commented Nov 6, 2018

Looks like TS currently only supports using number codes for diagnostics. Will sync with the TS team to see what we can do to improve the experience here

@egamma
Copy link
Member Author

egamma commented Nov 6, 2018

@mjbvz some cosmetic tuning would be to use a smaller number than 100000 for the tslint error code.

mjbvz added a commit that referenced this issue Nov 14, 2018
Make #16 less noticable. Will see what else we can do here
@mjbvz
Copy link
Contributor

mjbvz commented May 1, 2023

Closing as TSLint has been deprecated in favor of ESLint. We are archiving this repo as this project is no longer maintained

@mjbvz mjbvz closed this as completed May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants