Skip to content

Commit

Permalink
Code review feedback.
Browse files Browse the repository at this point in the history
  • Loading branch information
tjprescott committed Apr 16, 2024
1 parent 5c604fd commit 9ed268e
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions packages/compiler/test/parser.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
expectDiagnostics,
} from "../src/testing/expect.js";
import { dumpAST } from "./ast-test-utils.js";
import { strict } from "yargs";

Check warning on line 23 in packages/compiler/test/parser.test.ts

View workflow job for this annotation

GitHub Actions / Lint

'strict' is defined but never used. Allowed unused vars must match /^_/u

describe("compiler: parser", () => {
describe("import statements", () => {
Expand Down Expand Up @@ -721,15 +722,15 @@ describe("compiler: parser", () => {
`@doc("foo")\n#suppress "foo"\nnamespace Foo.Bar {}`,
(node) => {
const fooNs = node.statements[0];
assert(fooNs.kind === SyntaxKind.NamespaceStatement);
strictEqual(fooNs.kind, SyntaxKind.NamespaceStatement);
const barNs = (fooNs as any).statements;
assert(barNs.kind === SyntaxKind.NamespaceStatement);
assert(fooNs.id.sv === "Foo");
assert(barNs.id.sv === "Bar");
assert(fooNs.directives?.length === 0);
assert(fooNs.decorators.length === 0);
assert(barNs.directives?.length === 1);
assert(barNs.decorators.length === 1);
strictEqual(barNs.kind, SyntaxKind.NamespaceStatement);
strictEqual(fooNs.id.sv, "Foo");
strictEqual(barNs.id.sv, "Bar");
strictEqual(fooNs.directives?.length, 0);
strictEqual(fooNs.decorators.length, 0);
strictEqual(barNs.directives?.length, 1);
strictEqual(barNs.decorators.length, 1);
},
],
]);
Expand Down

0 comments on commit 9ed268e

Please sign in to comment.