Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playground build should check all sample files for diagnostics #1560

Closed
daviwil opened this issue Jan 19, 2023 · 1 comment · Fixed by #2977
Closed

Playground build should check all sample files for diagnostics #1560

daviwil opened this issue Jan 19, 2023 · 1 comment · Fixed by #2977
Assignees
@timotheeguerin
Milestone
Backlog

Comments

@daviwil
Copy link
Contributor

daviwil commented Jan 19, 2023

Following on from https://github.com/Azure/cadl-azure/pull/2448: we should add a check to ensure that playground samples both for this repo and cadl-azure should not have any diagnostics so that we don't ship with unusable samples.
@ghost ghost added the Needs Triage label Jan 19, 2023
@markcowl markcowl added this to the [2023] March milestone Jan 23, 2023
@markcowl
Copy link
Contributor

est: 5

@markcowl markcowl modified the milestones: [2023] March, [2023] May Jan 28, 2023
@markcowl markcowl modified the milestones: [2023] May, Backlog Feb 9, 2023
@timotheeguerin timotheeguerin mentioned this issue Mar 1, 2024
Merged
@timotheeguerin timotheeguerin self-assigned this Mar 1, 2024
markcowl pushed a commit to markcowl/cadl that referenced this issue Mar 8, 2024
@timotheeguerin @markcowl
Validate playground samples and fix docs to deprecated version (micro…
1dc41e9 
…soft#2977)

fix microsoft#1560

Json schema emitter also didn't respect the `noEmit` flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timotheeguerin timotheeguerin

Labels
None yet
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Validate playground samples and fix docs to deprecated version timotheeguerin/typespec
3 participants
@daviwil @timotheeguerin @markcowl