-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate TypeScript decorator signatures from extern dec
#2122
Generate TypeScript decorator signatures from extern dec
#2122
Conversation
Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status): Website: https://cadlwebsite.z1.web.core.windows.net/prs/2122/ |
extern dec
extern dec
…ture/dec-ts-sig
…n/typespec into feature/dec-ts-sig
All changed packages have been documented. |
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/2122/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/2122/ |
…ture/dec-ts-sig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not examine the changes to the decorators in detail, as we discussed these changes offline and I am assuming that all of the changes to types (to bring the typescript-side types inline with the declared signature) are all generally widenings.
Co-authored-by: Brian Terlson <brian.terlson@microsoft.com>
Co-authored-by: Brian Terlson <brian.terlson@microsoft.com>
Note this is added to
tspd
which is not published yet so this can be iterated over without any issues.Adds a decorator signature generator. Generates 2 files:
<namespace>.ts
: Contains the decorator signatures that can be imported and when declaring the decorators functions<namespace>.ts-test.ts
: Contains some test using typescript type system to make sure the package does reexport the right$<name>
for each decorator