Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement to the import auto complete #2936

Merged
merged 12 commits into from
Feb 20, 2024
Merged

Improvement to the import auto complete #2936

merged 12 commits into from
Feb 20, 2024

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Feb 17, 2024 •
edited

  • fix Directive autocomplete #2481 Autocomplete directive names
  • Stop crashing when completing invalid dir
  • Autocompleting dir with non letter char (e.g. -) will autocomplete correctly
  • Playground autocomplete imports
image

@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 17, 2024 •
edited

All changed packages have been documented.

@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/2936/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/2936/

@timotheeguerin timotheeguerin marked this pull request as ready for review February 20, 2024 17:08
@timotheeguerin timotheeguerin merged commit 753ca1a into microsoft:main Feb 20, 2024
14 checks passed
@timotheeguerin timotheeguerin deleted the ide/completion-improvments branch February 20, 2024 21:49
markcowl pushed a commit to markcowl/cadl that referenced this pull request Mar 5, 2024
@timotheeguerin @markcowl
Improvement to the import auto complete (microsoft#2936)
5b59a30 
- fix microsoft#2481 Autocomplete directive names
- Stop crashing when completing invalid dir
- Autocompleting dir with non letter char (e.g. `-`) will autocomplete
correctly
- Playground autocomplete imports
<img width="579" alt="image"
src="https://github.com/microsoft/typespec/assets/1031227/08e9e516-6472-4ab2-b3a5-30b4a8ce722d">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allenjzhang allenjzhang allenjzhang approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@daviwil daviwil Awaiting requested review from daviwil

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Directive autocomplete
3 participants
@timotheeguerin @azure-sdk @allenjzhang