Fix don't emit shared route error when verb don't match #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeguerin
requested review from
bterlson,
daviwil,
markcowl and
allenjzhang
as code owners
|
All changed packages have been documented. |
bterlson
reviewed
Feb 23, 2024
bterlson
reviewed
Feb 23, 2024
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/2948/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/2948/ |
Co-authored-by: Brian Terlson <brian.terlson@microsoft.com>
bterlson
reviewed
Feb 28, 2024
bterlson
approved these changes
Feb 28, 2024
Co-authored-by: Brian Terlson <brian.terlson@microsoft.com>
markcowl
pushed a commit
to markcowl/cadl
that referenced
this pull request
Mar 8, 2024
fix [microsoft#2925](microsoft#2925) Stop emitting the error if there is a shared route and a non shared route on a different verb. Also improve the error: - change message to be a little more clear - emit the error on every offending operation not just the first one we find an duplicate --------- Co-authored-by: Brian Terlson <brian.terlson@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2925
Stop emitting the error if there is a shared route and a non shared route on a different verb.
Also improve the error: