Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Model with spread indexer shouldn't validate explicit properites #3163

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Apr 12, 2024

This was causing errors in doing things like this

model Info {
  age: int32;
  ...Record<string>;
}

model Bar<T extends Info> {}

model Test {
  t: Bar<{
    age: 123;
    other: "abc";
  }>;
}

@timotheeguerin timotheeguerin changed the title Fix spread assignment Fix: Model with spread indexer shouldn't validate explicit properites Apr 12, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 12, 2024

All changed packages have been documented.

@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3163/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3163/

@timotheeguerin timotheeguerin enabled auto-merge (squash) April 12, 2024 18:38
@timotheeguerin timotheeguerin merged commit f30120d into microsoft:main Apr 12, 2024
25 checks passed
@timotheeguerin timotheeguerin deleted the fix/spread-assignment branch April 12, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants