Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: @path property should be included in unreachable models #3218

Merged

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Apr 23, 2024

fix #3217

@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 23, 2024

All changed packages have been documented.

  • @typespec/http
Show changes

@typespec/openapi3 - fix ✏️

Fix: @path property should be included in unreachable models

@typespec/http - fix ✏️

Fix: @path property shouldn't be applicableMetadata if the visibility contain Read

@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3218/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3218/

@timotheeguerin timotheeguerin added this pull request to the merge queue Apr 23, 2024
Merged via the queue into microsoft:main with commit 07b340a Apr 23, 2024
21 checks passed
@timotheeguerin timotheeguerin deleted the fix/unrechable-models-path branch April 23, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: OpenAPI 3 emitter incorrectly generate duplicate name error
3 participants