-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enhance summary for binarydata props #3289
Merged
jorgerangel-msft
merged 8 commits into
microsoft:main
from
jorgerangel-msft:binarydata-summary
May 9, 2024
Merged
feat: enhance summary for binarydata props #3289
jorgerangel-msft
merged 8 commits into
microsoft:main
from
jorgerangel-msft:binarydata-summary
May 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgerangel-msft
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
May 6, 2024 21:41
m-nash
reviewed
May 6, 2024
...ttp-client-csharp/generator/Microsoft.Generator.CSharp/src/Models/Types/ModelTypeProvider.cs
Outdated
Show resolved
Hide resolved
...ttp-client-csharp/generator/Microsoft.Generator.CSharp/src/Models/Types/ModelTypeProvider.cs
Outdated
Show resolved
Hide resolved
No changes needing a change description found. |
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3289/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3289/ |
…arydata-summary
m-nash
reviewed
May 9, 2024
...es/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Models/PropertyDescription.cs
Outdated
Show resolved
Hide resolved
m-nash
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the description of model properties that are of type
BinaryData
.