Organize versioning library #3309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeguerin
requested review from
bterlson,
markcowl and
allenjzhang
as code owners
|
All changed packages have been documented.
|
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3309/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3309/ |
markcowl
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versioning library is a big mess of things all into one file, this makes it hard to contribute. Did this originally because I was going to deal with multiple madeRequired and madeOptional over time but that will be done later but finished the cleanup anyway.
Split the versioning.ts into multiple separate logical files:
decorators.ts: Contains all the versioning decorators and accessorinternal-projection-functions.ts: Contains implementation of the helper function used inside the versioning projection(not meant for external use)projection.ts: Contains the projection building functionsversioning.ts: Contains the various versioning computation function(timeline, etc.)This makes it clearer of what is supposed to be public apis vs internal, waht is just mean for decorator, projection, etc.