Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling decorators for union variants in JSONSchema emitter #3398

Merged

Conversation

Veetaha
Copy link
Contributor

@Veetaha Veetaha commented May 18, 2024

Fixes #3391

Also refactored a minor problem of using a deprecated reexport of DuplicateTracker, not it's referenced from @typespec/compiler/utils directly, and another small typo.

@Veetaha
Copy link
Contributor Author

Veetaha commented May 18, 2024

@microsoft-github-policy-service agree

@Veetaha Veetaha force-pushed the feat/fix-union-variant-decorators branch from ddf6616 to d9e534a Compare May 18, 2024 15:26
@azure-sdk
Copy link
Collaborator

azure-sdk commented May 20, 2024

All changed packages have been documented.

  • @typespec/compiler
  • @typespec/json-schema
Show changes

@typespec/compiler - internal ✏️

Doc

@typespec/json-schema - fix ✏️

Fix decorators application for union variants

@microsoft microsoft deleted a comment from azure-pipelines bot May 20, 2024
@microsoft microsoft deleted a comment from azure-pipelines bot May 20, 2024
@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3398/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3398/

Copy link
Member

@timotheeguerin timotheeguerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for your contribution!

@timotheeguerin
Copy link
Member

/azp run typespec - pr tools

@microsoft microsoft deleted a comment from azure-pipelines bot May 20, 2024
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: JSONSchema emitter ignores decorator metadata is ignored on union variants
3 participants