Fix handling decorators for union variants in JSONSchema emitter #3398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veetaha
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
@microsoft-github-policy-service agree |
Veetaha
force-pushed
the
feat/fix-union-variant-decorators
branch
from
ddf6616
to
d9e534a
Compare
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3398/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3398/ |
timotheeguerin
approved these changes
May 20, 2024
|
/azp run typespec - pr tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 5, 2024
This was referenced Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3391
Also refactored a minor problem of using a deprecated reexport of
DuplicateTracker, not it's referenced from@typespec/compiler/utilsdirectly, and another small typo.