Analyze change ts #3415
Open
Analyze change ts #3415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No changes needing a change description found. |
timotheeguerin
commented
May 21, 2024
|
|
||
| - script: pnpm install | ||
| displayName: Install JavaScript Dependencies | ||
|
|
||
| - script: node $(Build.SourcesDirectory)/eng/common/scripts/resolve-target-branch.js |
There was a problem hiding this comment.
That should be able to be combined directly in the next script?
timotheeguerin
commented
May 24, 2024
There was a problem hiding this comment.
Those are a 1:1 conversion of the test existing, I'll update if you merge the other PR with the new ones
timotheeguerin
commented
May 24, 2024
timotheeguerin
commented
May 24, 2024
timotheeguerin
requested review from
bterlson,
markcowl and
allenjzhang
as code owners
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3415/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3415/ |
timotheeguerin
commented
May 28, 2024
| @@ -0,0 +1,22 @@ | |||
| import { AreaPaths } from "./labels.js"; | |||
There was a problem hiding this comment.
Kept it here for now, if we feel like this should move in here or another file, can do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the analyze-change.ps1 to typescript which allows to reuse a common config for which area belong to who as well as some other helpers.
The testing also is then all built-in the same system