Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom output viewer #3465

Merged
merged 14 commits into from
Jun 5, 2024

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented May 28, 2024

Provide a way to pass a custom program viewer to the playground. This should enable scnearios like having a TypeSpec UI viewer similar to swagger UI.
Moved the viewer selection to be some vertical tabs with icons to the right instead

File output viewer
image

Type graph viewer

image

Also fix issues related to the playground build not validating the typesript

@azure-sdk
Copy link
Collaborator

azure-sdk commented May 28, 2024

All changed packages have been documented.

  • @typespec/playground
Show changes

@typespec/playground - feature ✏️

Provide ability to add custom program viewers

@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3465/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3465/

Copy link
Member

@bterlson bterlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 10x better for sure.

@timotheeguerin timotheeguerin added this pull request to the merge queue Jun 5, 2024
Merged via the queue into microsoft:main with commit 12e26a3 Jun 5, 2024
21 checks passed
@timotheeguerin timotheeguerin deleted the custom-output-viewer branch June 5, 2024 23:13
@ravanscafi
Copy link

I apologize for the dumb question, but where's the Swagger UI now? How do I visualize it?
@timotheeguerin @bterlson

@timotheeguerin
Copy link
Member Author

hhm @ravanscafi that's a good catch seems like something got broken in the middle of this. I'll look into it

@timotheeguerin
Copy link
Member Author

Fix here #3552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants