Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAPI3: Fix Infinite recursion with self referencing model #732

Merged
merged 14 commits into from
Jul 25, 2022
Merged

OpenAPI3: Fix Infinite recursion with self referencing model #732

merged 14 commits into from
Jul 25, 2022

Conversation

jianyexi
Copy link
Contributor

@jianyexi jianyexi commented Jul 20, 2022 •
edited

@azure-pipelines
Copy link

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/732/

@jianyexi jianyexi changed the title Fix self ref Fix Infinite recursion with self referencing model Jul 20, 2022
@jianyexi jianyexi marked this pull request as ready for review July 20, 2022 15:26
@timotheeguerin timotheeguerin changed the title Fix Infinite recursion with self referencing model OpenAPI3: Fix Infinite recursion with self referencing model Jul 20, 2022
timotheeguerin
timotheeguerin reviewed Jul 21, 2022
View reviewed changes
Copy link
Member

@timotheeguerin timotheeguerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think the same change needs to be done to cadl-autorest as well. The issue in question was showing the cadl-autorest emitter.

packages/openapi3/src/openapi.ts Outdated Show resolved Hide resolved
@timotheeguerin timotheeguerin enabled auto-merge (squash) July 25, 2022 17:15
@timotheeguerin timotheeguerin merged commit aba2e8f into main Jul 25, 2022
@timotheeguerin timotheeguerin deleted the fix-self-ref branch July 25, 2022 17:36
@nguerrera nguerrera mentioned this pull request Aug 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheeguerin timotheeguerin timotheeguerin approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@daviwil daviwil Awaiting requested review from daviwil

@nguerrera nguerrera Awaiting requested review from nguerrera

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@mikekistler mikekistler Awaiting requested review from mikekistler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jianyexi @timotheeguerin