Skip to content

Commit

Permalink
Delete 'vcpkg cache'. (#1174)
Browse files Browse the repository at this point in the history
* Delete 'vcpkg cache'.

'vcpkg cache' was a helper for folks to attempt to implement caching systems. It prints the contents of the "packages" directory. It was a kind of helper for before we had real binary caching support built into the tool proper.

@vicroms indicates that telemetry shows fewer than 100 invocations of `vcpkg cache` in the last 90 days, so this should be OK to outright remove without a deprecation period.

* Also get rid of unique messages.
  • Loading branch information
BillyONeal committed Sep 6, 2023
1 parent f67d2aa commit 80b7926
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 96 deletions.
5 changes: 0 additions & 5 deletions include/vcpkg/base/message-data.inc.h
Original file line number Diff line number Diff line change
Expand Up @@ -417,10 +417,6 @@ DECLARE_MESSAGE(BuildTroubleshootingMessage4,
"Please use the prefilled template from {path} when reporting your issue.")
DECLARE_MESSAGE(BuiltInTriplets, (), "", "vcpkg built-in triplets:")
DECLARE_MESSAGE(BuiltWithIncorrectArchitecture, (), "", "The following files were built for an incorrect architecture:")
DECLARE_MESSAGE(CacheHelp,
(),
"",
"The argument should be a substring to search for or no argument to display all cached libraries.")
DECLARE_MESSAGE(CheckedOutGitSha, (msg::commit_sha), "", "Checked out Git SHA: {commit_sha}")
DECLARE_MESSAGE(CheckedOutObjectMissingManifest,
(),
Expand Down Expand Up @@ -1968,7 +1964,6 @@ DECLARE_MESSAGE(NewSpecifyNameVersionOrApplication,
"--application to indicate that the manifest is not intended to be used as a port.")
DECLARE_MESSAGE(NewVersionCannotBeEmpty, (), "", "--version cannot be empty.")
DECLARE_MESSAGE(NoArgumentsForOption, (msg::option), "", "The option --{option} does not accept an argument.")
DECLARE_MESSAGE(NoCachedPackages, (), "", "No packages are cached.")
DECLARE_MESSAGE(NoError, (), "", "no error")
DECLARE_MESSAGE(NoInstalledPackages,
(),
Expand Down
10 changes: 0 additions & 10 deletions include/vcpkg/commands.cache.h

This file was deleted.

2 changes: 0 additions & 2 deletions locales/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,6 @@
"_CMakeToolChainFile.comment": "An example of {path} is /foo/bar.",
"CMakeUsingExportedLibs": "To use exported libraries in CMake projects, add {value} to your CMake command line.",
"_CMakeUsingExportedLibs.comment": "{value} is a CMake command line switch of the form -DFOO=BAR",
"CacheHelp": "The argument should be a substring to search for or no argument to display all cached libraries.",
"CheckedOutGitSha": "Checked out Git SHA: {commit_sha}",
"_CheckedOutGitSha.comment": "An example of {commit_sha} is 7cfad47ae9f68b183983090afd6337cd60fd4949.",
"CheckedOutObjectMissingManifest": "The checked-out object does not contain a CONTROL file or vcpkg.json file.",
Expand Down Expand Up @@ -1101,7 +1100,6 @@
"NewVersionCannotBeEmpty": "--version cannot be empty.",
"NoArgumentsForOption": "The option --{option} does not accept an argument.",
"_NoArgumentsForOption.comment": "An example of {option} is editable.",
"NoCachedPackages": "No packages are cached.",
"NoError": "no error",
"NoInstalledPackages": "No packages are installed. Did you mean `search`?",
"_NoInstalledPackages.comment": "The name 'search' is the name of a command that is not localized.",
Expand Down
75 changes: 0 additions & 75 deletions src/vcpkg/commands.cache.cpp

This file was deleted.

2 changes: 0 additions & 2 deletions src/vcpkg/commands.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
#include <vcpkg/commands.bootstrap-standalone.h>
#include <vcpkg/commands.build-external.h>
#include <vcpkg/commands.build.h>
#include <vcpkg/commands.cache.h>
#include <vcpkg/commands.check-support.h>
#include <vcpkg/commands.ci-clean.h>
#include <vcpkg/commands.ci-verify-versions.h>
Expand Down Expand Up @@ -80,7 +79,6 @@ namespace vcpkg
{"add", command_add_and_exit},
{"x-add-version", command_add_version_and_exit},
{"autocomplete", command_autocomplete_and_exit},
{"cache", command_cache_and_exit},
{"x-ci-clean", command_ci_clean_and_exit},
{"x-ci-verify-versions", command_ci_verify_versions_and_exit},
{"create", command_create_and_exit},
Expand Down
2 changes: 0 additions & 2 deletions src/vcpkg/commands.help.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include <vcpkg/commands.add.h>
#include <vcpkg/commands.build-external.h>
#include <vcpkg/commands.build.h>
#include <vcpkg/commands.cache.h>
#include <vcpkg/commands.check-support.h>
#include <vcpkg/commands.ci-clean.h>
#include <vcpkg/commands.ci-verify-versions.h>
Expand Down Expand Up @@ -127,7 +126,6 @@ namespace
// bootstrap-standalone intentionally has no help topic
{"build", command_topic_fn<CommandBuildMetadata>},
{"build-external", command_topic_fn<CommandBuildExternalMetadata>},
{"cache", command_topic_fn<CommandCacheMetadata>},
{"x-check-support", command_topic_fn<CommandCheckSupportMetadata>},
{"ci", command_topic_fn<CommandCiMetadata>},
{"x-ci-clean", command_topic_fn<CommandCiCleanMetadata>},
Expand Down

0 comments on commit 80b7926

Please sign in to comment.