Fix VS static analyzer warnings. #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Optional and expected were not properly forwarding noexcept for their special member functions, so is_nothrow_move_constructible_v<Expected<T>> was false for all T. (This has bad implications if the expecteds are in a vector) 2. system.process.cpp uses a 32k stack buffer but it's the "top" of the stack so we don't care. 3. dependencies.cpp was calling std::move() on a constant variable `info_ptr->default_features`; I changed the declarations to better show that this was const. 4. (Drive by) All users of make_optional were actually doing emplacement.
|
Thanks for fixing this! I noticed an exceptionally high number of copies out of Expected/ Optional in the past but was unable to find the reason for this. |
I doubt this is going to change much about that but it's worth a shot |
ras0219-msft
approved these changes
Oct 25, 2023
| @@ -48,25 +56,28 @@ namespace vcpkg | |||
| } | |||
| } | |||
|
|
|||
| ~OptionalStorage() noexcept | |||
| ~OptionalStorage() | |||
There was a problem hiding this comment.
Why should this not be noexcept?
There was a problem hiding this comment.
It is a destructor, destructors are noexcept without being annotated as such (And we don't annotate other destructors)
Destructors should get noexcept annotations only if they are doing noexcept(false)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
info_ptr->default_features; I changed the declarations to better show that this was const.