Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the changelog updated ports count. #1245

Merged
merged 1 commit into from Oct 24, 2023
Merged

Fix the changelog updated ports count. #1245

merged 1 commit into from Oct 24, 2023

Conversation

BillyONeal
Copy link
Member

Drive by: get rid of from/to

Thanks to @autoantwort for pointing this out.

@BillyONeal
Fix the changelog updated ports count.
793ab81 
Drive by: get rid of from/to
@autoantwort
Copy link
Contributor

No from/to because it is implicit via the last release?

@BillyONeal
Copy link
Member Author

No from/to because it is implicit via the last release?

I just don't think anyone cares about the 'from' part, and the 'to' part is duplicated in the title:

example of previous release with from-to

@autoantwort
Copy link
Contributor

autoantwort commented Oct 20, 2023 •
edited

Is the to part different by mistake?

@BillyONeal
Copy link
Member Author

Is the to part different by mistake?

What a great example of why that line is bad! :)

@BillyONeal BillyONeal merged commit ce5e3b7 into microsoft:main Oct 24, 2023
5 checks passed
@BillyONeal BillyONeal deleted the fix-port-count branch October 24, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicroms vicroms vicroms approved these changes

@autoantwort autoantwort autoantwort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@BillyONeal @autoantwort @vicroms