Delocalize error: warning: and note:. #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Response to code review comment microsoft#1239 (comment)
ras0219-msft
approved these changes
Oct 31, 2023
include/vcpkg/base/messages.h
Outdated
| inline constexpr StringLiteral InternalErrorPrefix = "internal error: "; | ||
| inline constexpr StringLiteral NotePrefix = "note: "; | ||
| inline constexpr StringLiteral WarningPrefix = "warning: "; | ||
|
|
There was a problem hiding this comment.
Suggested change
| LocalizedString error_prefix(); | |
| LocalizedString internal_error_prefix(); | |
| LocalizedString note_prefix(); | |
| LocalizedString warning_prefix(); |
These are used widely enough that I think it improves clarity:
LocalizedString::from_raw(ErrorPrefix).append(msgMyErrorStuff)to
error_prefix().append(msgMyErrorStuff)
src/vcpkg/base/parse.cpp
Outdated
Comment on lines
39
to
46
| if (kind == MessageKind::Warning) | ||
| { | ||
| res.append(msgWarningMessage); | ||
| res.append_raw(WarningPrefix); | ||
| } | ||
| else | ||
| { | ||
| res.append(msgErrorMessage); | ||
| res.append_raw(ErrorPrefix); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (kind == MessageKind::Warning) | |
| { | |
| res.append(msgWarningMessage); | |
| res.append_raw(WarningPrefix); | |
| } | |
| else | |
| { | |
| res.append(msgErrorMessage); | |
| res.append_raw(ErrorPrefix); | |
| } | |
| res.append_raw(kind == MessageKind::Warning ? WarningPrefix : ErrorPrefix); |
| } | ||
|
|
||
| if (!mismatches.arguments_without_comment.empty() || !mismatches.comments_without_argument.empty()) | ||
| { | ||
| has_errors = true; | ||
| msg::println_error(msgGenerateMsgIncorrectComment, msg::value = msg.name); | ||
| msg::print(LocalizedString::from_raw(ErrorPrefix) | ||
| .append_raw(fmt::format("message {} has an incorrect comment:\n", msg.name))); | ||
|
|
||
| for (const auto& arg : mismatches.arguments_without_comment) |
There was a problem hiding this comment.
Double check these -- the message seems opposite from the member name arguments_without_comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Response to code review comment #1239 (comment)
I spoke with localization team and compiler team and not localizing these are what the compiler does.