Audit headers for overzealous inclusion reported by Visual Studio #1273

BillyONeal · 2023-11-08T23:41:14Z

I did this analysis while helping the Visual Studio team make the 'dim unused includes' feature better.

It didn't make a performance difference in my testing:

Benchmark on a 7950X

Full Rebuild Before:
15:37:07:635 - 15:36:42:065 = 25 seconds

Full Rebuild After:
15:35:18:879 - 15:34:53:398 = 25 seconds

but might for folks on lower spec machines and is certainly 'cleaner'.

…to reduce a bug for the intellisense team.

BillyONeal · 2023-11-08T23:43:30Z

include/vcpkg/dependencies.h

 #include <vector>

 namespace vcpkg
 {
-    struct GraphRandomizer;


This is why base/fwd/graphs.h got added

BillyONeal · 2023-11-08T23:44:32Z

src/vcpkg.cpp

@@ -42,6 +32,10 @@ using namespace vcpkg;

 namespace
 {
+    std::atomic<int> g_init_console_cp(0);


This was the entire contents of globalstate.cpp and it was only used here.

BillyONeal added 2 commits November 8, 2023 14:27

Audit for overzealous headers in other headers. Ran into this trying …

2ac1bb5

…to reduce a bug for the intellisense team.

Also audit .cpp files.

61fed7d

BillyONeal commented Nov 8, 2023

View reviewed changes

BillyONeal added 2 commits November 8, 2023 15:46

Fix macos warning.

9c4f8ff

format

98803b6

ras0219-msft approved these changes Nov 9, 2023

View reviewed changes

BillyONeal merged commit dfb60db into microsoft:main Nov 9, 2023
5 checks passed

BillyONeal deleted the includes branch November 9, 2023 23:06

Provide feedback