Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm64ec platform expression #1352

Merged
merged 2 commits into from Feb 22, 2024
Merged

Conversation

autoantwort
Copy link
Contributor

@kobykahane Or do you prefer that arm64 also matches arm64ec

@kobykahane
Copy link

@kobykahane Or do you prefer that arm64 also matches arm64ec

Ideally arm64 and arm64ec should be separate, because in my use case, I would like to build the capstone port as follows:

  • For all triplets, with the 'diet' feature.
  • For the x86 and arm64ec triplets, with the 'x86' feature.
  • For the arm64 and arm64ec triplets, with the 'arm64' feature.
    (In other words, on ARM64EC I would like both the x86 and ARM64 disassemblers, because both types of code might be present).
    Looking something like:
    {
      "name": "capstone",
      "default-features": false,
      "features": [
        {
          "name": "arm64",
          "platform": "arm64,arm64ec"
        },
        "diet",
        {
          "name": "x86",
          "platform": "x86,arm64ec"
        }
      ]
    },

Co-authored-by: Billy O'Neal <bion@microsoft.com>
@BillyONeal BillyONeal merged commit c549365 into microsoft:main Feb 22, 2024
5 checks passed
@BillyONeal
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants