Paths in PrebuildInfo should be `Path` instead of `std::string` #1366

Thomas1664 · 2024-03-21T12:08:21Z

Store files as vector of Path right away.
This is semantically more correct and saves extra string copies.
Turn external_toolchain_file into a Path
Drive by: Don't leak i outside the loop

Neumann-A · 2024-03-21T13:19:58Z

Optional<std::string> external_toolchain_file; should probably also be a path

src/vcpkg/commands.build.cpp

include/vcpkg/commands.build.h

src/vcpkg/commands.build.cpp

Co-authored-by: autoantwort <41973254+autoantwort@users.noreply.github.com>

src/vcpkg/commands.build.cpp

BillyONeal · 2024-03-25T23:32:15Z

Thanks!

Improve "Hash additional files"

96ad2a8

Neumann-A reviewed Mar 21, 2024

View reviewed changes

src/vcpkg/commands.build.cpp Show resolved Hide resolved

Neumann-A reviewed Mar 21, 2024

View reviewed changes

src/vcpkg/commands.build.cpp Outdated Show resolved Hide resolved

Neumann-A reviewed Mar 21, 2024

View reviewed changes

include/vcpkg/commands.build.h Show resolved Hide resolved

Neumann-A reviewed Mar 21, 2024

View reviewed changes

src/vcpkg/commands.build.cpp Outdated Show resolved Hide resolved

make external_toolchain_file also a Path

2db9b4c

Thomas1664 changed the title ~~Improve "Hash additional files"~~ Paths in PrebuildInfo should be Path instead of std::string Mar 21, 2024

autoantwort reviewed Mar 21, 2024

View reviewed changes

src/vcpkg/commands.build.cpp Outdated Show resolved Hide resolved

Thomas1664 and others added 2 commits March 22, 2024 00:23

Use fmap instead

44f8d6a

Co-authored-by: autoantwort <41973254+autoantwort@users.noreply.github.com>

format

55241ae

dg0yt reviewed Mar 22, 2024

View reviewed changes

src/vcpkg/commands.build.cpp Outdated Show resolved Hide resolved

make hash temporary

c5f8d01

BillyONeal merged commit de85ec9 into microsoft:main Mar 25, 2024
5 checks passed

Thomas1664 deleted the hash-additional-files branch March 26, 2024 08:53

Provide feedback