Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorize multi-triplet dot graphs #1371

Merged
merged 3 commits into from Apr 8, 2024
Merged

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Mar 24, 2024

Just 8361878
Depends on (for now, includes) #1369 and #1370.

Example:

vcpkg depend-info proj:arm64-linux proj tiff[core] --triplet x64-linux-dynamic --dot | dot -Tpng -oimg.png && xdg-open img.png

Output:
img

@autoantwort
Copy link
Contributor

So non default triplet -> red; default triplet -> black; host triplet -> gray?
Maybe use blue instead of red, red looks like an error 😅

@dg0yt
Copy link
Contributor Author

dg0yt commented Mar 28, 2024

Maybe use blue instead of red, red looks like an error 😅

Done.
(And there is room for "error", such as "unsupported".)

@dg0yt dg0yt marked this pull request as ready for review March 28, 2024 07:27
@BillyONeal
Copy link
Member

I'm a bit concerned that grey is a bit too close to the background color; I'm worried about accessibility requirements, that sort of thing.

How about DimGray, HTML color #696969 ?
or perhaps DarkSlateGray, HTML color #2F4F4F ?

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with the code here pending quibbles over the specific colors and an Ok from our PM team /cc @AugP

@BillyONeal
Copy link
Member

I'm a bit concerned that grey is a bit too close to the background color; I'm worried about accessibility requirements, that sort of thing.

How about DimGray, HTML color #696969 ? or perhaps DarkSlateGray, HTML color #2F4F4F ?

I note that on https://graphviz.org/doc/info/colors.html they use black text on gray and white text on dimgray and darkslategray suggesting that the latter two are more appropriate for contrast against a white background

@AugP
Copy link

AugP commented Apr 4, 2024

I have no objections to this, assuming it passes our accessibility compliance requirements. @BillyONeal can you confirm if this conforms to our accessibility requirements?

@dg0yt
Copy link
Contributor Author

dg0yt commented Apr 5, 2024

After some playing with different candidates, I switched to gray51. This is the lightest (=most distant from black) gray which is still label with white text (=distant enough from white) on https://graphviz.org/doc/info/colors.html.

img

@dg0yt
Copy link
Contributor Author

dg0yt commented Apr 5, 2024

FTR all default native requests remain B/W.

@BillyONeal BillyONeal merged commit 77fa382 into microsoft:main Apr 8, 2024
5 checks passed
@BillyONeal
Copy link
Member

Thanks :)

@dg0yt dg0yt deleted the dot-color branch April 9, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants