Add new post check for share folder

[JackBoosY]

Check for non-lowercase share folder.

[JackBoosY]

@ras0219-msft For regression, should I split the message to fix it?

[BillyONeal]

I fixed the build failures and I think the change is overall good. Because it adds a new post-build lint we need to pre-run it on the catalog to double check that the world won't break when deployed. @ras0219-msft Can you confirm you're OK with this now and I can kick that off?

[BillyONeal]

@ras0219-msft For regression, should I split the message to fix it?

The error was complaining that the localized message ended with \n, thus being likely to create a bug that was present here where it was passed to println doubling the terminal \ns. This check was added in #553

[ras0219-msft]

LGTM. @BillyONeal if you could kick off the test that would be great!

[dg0yt]

Well, you can just use the file lists from CI... I find

• more than 7000 installed files matching :/share/[A-Z]
• more then 600 CMake configs, by :/share/[A-Z].+/.*onfig.cmake
• more then 60 port dirs, by :/share/[A-Z].+/vcpkg_abi

[autoantwort]

Why folders in the share folder should be always lowercase?

[BillyONeal]

Well, you can just use the file lists from CI... I find

• more than 7000 installed files matching :/share/[A-Z]
• more then 600 CMake configs, by :/share/[A-Z].+/.*onfig.cmake
• more then 60 port dirs, by :/share/[A-Z].+/vcpkg_abi

Good point!

Why folders in the share folder should be always lowercase?

The name vcpkg creates is always, for example, share/${PORT}/vcpkg_abi_info.txt, and ${PORT} is always lowercase. When there are capital ones, it means that users will get different behavior on case sensitive vs. case insensitive file systems, which has been the source of a lot of broken behavior. (like 'works on linux but not windows because the directory names differed only in case')

[BillyONeal]

Why folders in the share folder should be always lowercase?

Example we want the new check to block microsoft/vcpkg#26284 (comment)

[dg0yt]

Port ogre installs resources to share/OGRE. To be patched?

[dg0yt]

Port ogre installs resources to share/OGRE. To be patched?

This mirrors the headers in include/OGRE and the plugins in lib/OGRE.

[ras0219-msft]

Port ogre installs resources to share/OGRE. To be patched?

That's a great point. We do need a policy setting to control the check. Then, we should evaluate whether ogre should disable the policy or whether patching is appropriate. I don't think that matching lib/OGRE/ or include/OGRE/ is by itself sufficient, but if there is an expectation of hardcoded paths containing share/OGRE/ then we may need to simply accept the differences per host platform.

[ras0219-msft]

@JackBoosY Once again, thank you for all your hard work on vcpkg! Would you like to continue this PR or should we take ownership and bring it to completion?

[JackBoosY]

@ras0219-msft I will continue this PR.

[JackBoosY]

Looks good now.

[dg0yt]

It still needs a policy to disable it, and changes to app. 60 ports.

[JackBoosY]

@ras0219-msft @BillyONeal Any feedback?

[dg0yt]

The feedback is only four days old (#675 (comment))

We do need a policy setting to control the check.

[JackBoosY]

The feedback is only four days old (#675 (comment))

We do need a policy setting to control the check.

Ah I'm blind...

[JackBoosY]

So what about the 60+ ports / port OGRE?

[dg0yt]

FTR at least to open PRs add new ports with mixed case directories via vpckg_cmake_config_fixup(PACKAGE_NAME <Mixed>). Maybe it would be a good idea to start with improving this function: Convert input PACKAGE_NAME to lower case directory name where feasible.

[JackBoosY]

FTR at least to open PRs add new ports with mixed case directories via vpckg_cmake_config_fixup(PACKAGE_NAME <Mixed>). Maybe it would be a good idea to start with improving this function: Convert input PACKAGE_NAME to lower case directory name where feasible.

Will do that after microsoft/vcpkg#29880 microsoft/vcpkg#29882 microsoft/vcpkg#29883 microsoft/vcpkg#29884 and microsoft/vcpkg#29918 are merged.

[JackBoosY]

Depends on microsoft/vcpkg#31053