Introduce VCPKG_HASH_ADDITIONAL_FILES #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autoantwort
reviewed
Nov 8, 2022
Neumann-A
commented
Nov 8, 2022
Neumann-A
commented
Nov 12, 2022
Neumann-A
commented
Nov 12, 2022
Neumann-A
commented
Nov 12, 2022
Neumann-A
commented
Nov 13, 2022
azure-pipelines/e2e_ports/hash-additional/vcpkg-test-hash-additional/vcpkg.json
Outdated
Show resolved
Hide resolved
Neumann-A
commented
Nov 13, 2022
ras0219-msft
reviewed
Mar 1, 2023
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Neumann-A
commented
Mar 1, 2023
azure-pipelines/e2e_ports/hash-additional/vcpkg-test-hash-additional/portfile.cmake
Outdated
Show resolved
Hide resolved
|
@ras0219-msft Is there still something which needs to be done? |
ras0219-msft
approved these changes
Apr 10, 2023
# Conflicts: # include/vcpkg/commands.build.h # src/vcpkg/cmakevars.cpp # src/vcpkg/commands.build.cpp
# Conflicts: # src/vcpkg/commands.build.cpp # src/vcpkg/tools.cpp
|
@ras0219-msft Any update? |
vicroms
reviewed
Dec 19, 2023
Neumann-A
commented
Dec 19, 2023
- fix typo - rephrase description sentence Co-authored-by: Victor Romero <romerosanchezv@gmail.com>
Neumann-A
commented
Dec 20, 2023
Neumann-A
commented
Dec 20, 2023
Neumann-A
commented
Dec 20, 2023
Neumann-A
commented
Dec 20, 2023
Thomas1664
reviewed
Dec 20, 2023
|
@vicroms @ras0219-msft: ping for update |
|
Ok, the team met today and we agree with this mechanism. We did touch on the edge cases specifically: we like relative paths, nonexistent files, and directories being errors. Some code has changed since the last code review, so once we complete a review of the changes, this is good to go! |
|
@ras0219-msft @vicroms ping |
# Conflicts: # src/vcpkg/commands.build.cpp
vicroms
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to define additional files which should be included in the abi hash via setting
VCPKG_HASH_ADDITIONAL_FILESto a list of files for inclusion.Bonus: Fixed some compiler warnings I got using clang-clcloses microsoft/vcpkg#26863